Commit 3ccf393c authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

r8169: remove optional size argument in calls to strscpy 



Minor simplification of the code by removing the optional size argument.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/d560ec66-848e-4290-818a-ce28f39de493@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5e3c5a2b

drivers/net/ethernet/realtek/r8169_firmware.c

+1 −1
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ static bool rtl_fw_format_ok(struct rtl_fw *rtl_fw) 
		if (size > (fw->size - start) / FW_OPCODE_SIZE)

			return false;



		strscpy(rtl_fw->version, fw_info->version, RTL_VER_SIZE);

		strscpy(rtl_fw->version, fw_info->version);



		pa->code = (__le32 *)(fw->data + start);

		pa->size = size;

drivers/net/ethernet/realtek/r8169_main.c

+3 −4
Original line number Diff line number Diff line
@@ -1784,12 +1784,11 @@ static void rtl8169_get_drvinfo(struct net_device *dev, 
	struct rtl8169_private *tp = netdev_priv(dev);

	struct rtl_fw *rtl_fw = tp->rtl_fw;



	strscpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));

	strscpy(info->bus_info, pci_name(tp->pci_dev), sizeof(info->bus_info));

	strscpy(info->driver, KBUILD_MODNAME);

	strscpy(info->bus_info, pci_name(tp->pci_dev));

	BUILD_BUG_ON(sizeof(info->fw_version) < sizeof(rtl_fw->version));

	if (rtl_fw)

		strscpy(info->fw_version, rtl_fw->version,

			sizeof(info->fw_version));

		strscpy(info->fw_version, rtl_fw->version);

}



static int rtl8169_get_regs_len(struct net_device *dev)