Commit 3d3352e7 authored by Alexandre Courbot's avatar Alexandre Courbot
Browse files

gpu: nova-core: select RUST_FW_LOADER_ABSTRACTIONS 

RUST_FW_LOADER_ABSTRACTIONS was depended on by NOVA_CORE, but NOVA_CORE
is selected by DRM_NOVA. This creates a situation where, if DRM_NOVA is
selected, NOVA_CORE gets enabled but not RUST_FW_LOADER_ABSTRACTIONS,
which results in a build error.

Since the firmware loader is an implementation detail of the driver, it
should be enabled along with it, so change the "depends on" to a
"select".

Fixes: 54e6baf1 ("gpu: nova-core: add initial driver stub")
Closes: https://lore.kernel.org/oe-kbuild-all/202512061721.rxKGnt5q-lkp@intel.com/


Tested-by: default avatarAlyssa Ross <hi@alyssa.is>
Acked-by: default avatarDanilo Krummrich <dakr@kernel.org>
Link: https://patch.msgid.link/20251106-b4-select-rust-fw-v3-2-771172257755@nvidia.com


Signed-off-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
parent f371d2af

drivers/gpu/nova-core/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ config NOVA_CORE 
	depends on 64BIT

	depends on PCI

	depends on RUST

	depends on RUST_FW_LOADER_ABSTRACTIONS

	select RUST_FW_LOADER_ABSTRACTIONS

	select AUXILIARY_BUS

	default n

	help