Unverified Commit 3d86ced9 authored by Chun-Kuang Hu's avatar Chun-Kuang Hu Committed by AngeloGioacchino Del Regno
Browse files

soc: mediatek: cmdq: Add cmdq_pkt_eoc() helper function 



cmdq_pkt_eoc() append eoc command to CMDQ packet. eoc command
would ask GCE to generate IRQ. It's usually appended to the end
of packet to notify all command in the packet is done.

Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
Link: https://lore.kernel.org/r/20240222154120.16959-6-chunkuang.hu@kernel.org


Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent 698cdcb1

drivers/soc/mediatek/mtk-cmdq-helper.c

+10 −0
Original line number Diff line number Diff line
@@ -414,6 +414,16 @@ int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_pa) 
}

EXPORT_SYMBOL(cmdq_pkt_jump_rel);



int cmdq_pkt_eoc(struct cmdq_pkt *pkt)

{

	struct cmdq_instruction inst = { {0} };



	inst.op = CMDQ_CODE_EOC;

	inst.value = CMDQ_EOC_IRQ_EN;

	return cmdq_pkt_append_command(pkt, inst);

}

EXPORT_SYMBOL(cmdq_pkt_eoc);



int cmdq_pkt_finalize(struct cmdq_pkt *pkt)

{

	struct cmdq_instruction inst = { {0} };

include/linux/soc/mediatek/mtk-cmdq.h

+19 −0
Original line number Diff line number Diff line
@@ -281,6 +281,20 @@ static inline int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_ 
 */

int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_pa);



/**

 * cmdq_pkt_eoc() - Append EOC and ask GCE to generate an IRQ at end of execution

 * @pkt:	The CMDQ packet

 *

 * Appends an End Of Code (EOC) command to the CMDQ packet and asks the GCE

 * to generate an interrupt at the end of the execution of all commands in

 * the pipeline.

 * The EOC command is usually appended to the end of the pipeline to notify

 * that all commands are done.

 *

 * Return: 0 for success or negative error number

 */

int cmdq_pkt_eoc(struct cmdq_pkt *pkt);



/**

 * cmdq_pkt_finalize() - Append EOC and jump command to pkt.

 * @pkt:	the CMDQ packet
@@ -412,6 +426,11 @@ static inline int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_p 
	return -EINVAL;

}



static inline int cmdq_pkt_eoc(struct cmdq_pkt *pkt)

{

	return -EINVAL;

}



static inline int cmdq_pkt_finalize(struct cmdq_pkt *pkt)

{

	return -EINVAL;