Unverified Commit 3dc8c733 authored by Haotian Zhang's avatar Haotian Zhang Committed by Mark Brown
Browse files

ASoC: codecs: va-macro: fix resource leak in probe error path 



In the commit referenced by the Fixes tag, clk_hw_get_clk()
was added in va_macro_probe() to get the fsgen clock,
but forgot to add the corresponding clk_put() in va_macro_remove().
This leads to a clock reference leak when the driver is unloaded.

Switch to devm_clk_hw_get_clk() to automatically manage the
clock resource.

Fixes: 30097967 ("ASoC: codecs: va-macro: use fsgen as clock")
Suggested-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://patch.msgid.link/20251106143114.729-1-vulab@iscas.ac.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 84f5526e

sound/soc/codecs/lpass-va-macro.c

+1 −1
Original line number Diff line number Diff line
@@ -1638,7 +1638,7 @@ static int va_macro_probe(struct platform_device *pdev) 
	if (ret)

		goto err_clkout;



	va->fsgen = clk_hw_get_clk(&va->hw, "fsgen");

	va->fsgen = devm_clk_hw_get_clk(dev, &va->hw, "fsgen");

	if (IS_ERR(va->fsgen)) {

		ret = PTR_ERR(va->fsgen);

		goto err_clkout;