Commit 3df69216 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans de Goede
Browse files

platform/x86: hp-wmi: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/a6b074b7ee37f3682da4b3f39ea40af97add64c2.1701726190.git.u.kleine-koenig@pengutronix.de


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent f2a2d85a

drivers/platform/x86/hp/hp-wmi.c

+2 −4
Original line number Diff line number Diff line
@@ -1478,7 +1478,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device) 
	return 0;

}



static int __exit hp_wmi_bios_remove(struct platform_device *device)

static void __exit hp_wmi_bios_remove(struct platform_device *device)

{

	int i;
@@ -1502,8 +1502,6 @@ static int __exit hp_wmi_bios_remove(struct platform_device *device) 


	if (platform_profile_support)

		platform_profile_remove();



	return 0;

}



static int hp_wmi_resume_handler(struct device *device)
@@ -1560,7 +1558,7 @@ static struct platform_driver hp_wmi_driver __refdata = { 
		.pm = &hp_wmi_pm_ops,

		.dev_groups = hp_wmi_groups,

	},

	.remove = __exit_p(hp_wmi_bios_remove),

	.remove_new = __exit_p(hp_wmi_bios_remove),

};



static umode_t hp_wmi_hwmon_is_visible(const void *data,