Commit 3e36031c authored by Shannon Nelson's avatar Shannon Nelson Committed by Jakub Kicinski
Browse files

pds_core: no health-thread in VF path 



The VFs don't run the health thread, so don't try to
stop or restart the non-existent timer or work item.

Fixes: d9407ff1 ("pds_core: Prevent health thread from running during reset/remove")
Reviewed-by: default avatarBrett Creeley <brett.creeley@amd.com>
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20240210002002.49483-1-shannon.nelson@amd.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2f74258d

drivers/net/ethernet/amd/pds_core/main.c

+6 −0
Original line number Diff line number Diff line
@@ -451,6 +451,9 @@ static void pdsc_remove(struct pci_dev *pdev) 


static void pdsc_stop_health_thread(struct pdsc *pdsc)

{

	if (pdsc->pdev->is_virtfn)

		return;



	timer_shutdown_sync(&pdsc->wdtimer);

	if (pdsc->health_work.func)

		cancel_work_sync(&pdsc->health_work);
@@ -458,6 +461,9 @@ static void pdsc_stop_health_thread(struct pdsc *pdsc) 


static void pdsc_restart_health_thread(struct pdsc *pdsc)

{

	if (pdsc->pdev->is_virtfn)

		return;



	timer_setup(&pdsc->wdtimer, pdsc_wdtimer_cb, 0);

	mod_timer(&pdsc->wdtimer, jiffies + 1);

}