Commit 3e54d3b4 authored Dec 01, 2025 by Marc Kleine-Budde

can: gs_usb: gs_can_open(): fix error handling

Commit 2603be9e ("can: gs_usb: gs_can_open(): improve error handling")
added missing error handling to the gs_can_open() function.

The driver uses 2 USB anchors to track the allocated URBs: the TX URBs in
struct gs_can::tx_submitted for each netdev and the RX URBs in struct
gs_usb::rx_submitted for the USB device. gs_can_open() allocates the RX
URBs, while TX URBs are allocated during gs_can_start_xmit().

The cleanup in gs_can_open() kills all anchored dev->tx_submitted
URBs (which is not necessary since the netdev is not yet registered), but
misses the parent->rx_submitted URBs.

Fix the problem by killing the rx_submitted instead of the tx_submitted.

Fixes: 2603be9e ("can: gs_usb: gs_can_open(): improve error handling")
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20251210-gs_usb-fix-error-handling-v1-1-d6a5a03f10bb@pengutronix.de

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 6abd4577

drivers/net/can/usb/gs_usb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1074,7 +1074,7 @@ static int gs_can_open(struct net_device *netdev)
		usb_free_urb(urb);
		out_usb_kill_anchored_urbs:
		if (!parent->active_channels) {
		usb_kill_anchored_urbs(&dev->tx_submitted);
		usb_kill_anchored_urbs(&parent->rx_submitted);

		if (dev->feature & GS_CAN_FEATURE_HW_TIMESTAMP)
		gs_usb_timestamp_stop(parent);