Commit 3e707b07 authored by Mickaël Salaün's avatar Mickaël Salaün Committed by Kees Cook
Browse files

selftests: ktap_helpers: Fix uninitialized variable 



__ktap_test() may be called without the optional third argument which is
an issue for scripts using `set -u` to detect uninitialized variables
and potential bugs.

Fix this optional "directive" argument by either using the third
argument or an empty string.

This is required for the next commit to properly test script execution
control.

Cc: Kees Cook <kees@kernel.org>
Cc: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Fixes: 14571ab1 ("kselftest: Add new test for detecting unprobed Devicetree devices")
Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
Link: https://lore.kernel.org/r/20241212174223.389435-7-mic@digikod.net


Signed-off-by: default avatarKees Cook <kees@kernel.org>
parent faf2d88e

tools/testing/selftests/kselftest/ktap_helpers.sh

+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ ktap_skip_all() { 
__ktap_test() {

	result="$1"

	description="$2"

	directive="$3" # optional

	directive="${3:-}" # optional



	local directive_str=

	[ ! -z "$directive" ] && directive_str="# $directive"