Commit 3eb030c6 authored by Herve Codina's avatar Herve Codina Committed by Rob Herring
Browse files

of: address: Remove duplicated functions 



The recently added of_bus_default_flags_translate() performs the exact
same operation as of_bus_pci_translate() and of_bus_isa_translate().

Avoid duplicated code replacing both of_bus_pci_translate() and
of_bus_isa_translate() with of_bus_default_flags_translate().

Signed-off-by: default avatarHerve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20231017110221.189299-3-herve.codina@bootlin.com


Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 42604f8e

drivers/of/address.c

+2 −11
Original line number Diff line number Diff line
@@ -216,10 +216,6 @@ static u64 of_bus_pci_map(__be32 *addr, const __be32 *range, int na, int ns, 
	return da - cp;

}



static int of_bus_pci_translate(__be32 *addr, u64 offset, int na)

{

	return of_bus_default_translate(addr + 1, offset, na - 1);

}

#endif /* CONFIG_PCI */



/*
@@ -343,11 +339,6 @@ static u64 of_bus_isa_map(__be32 *addr, const __be32 *range, int na, int ns, 
	return da - cp;

}



static int of_bus_isa_translate(__be32 *addr, u64 offset, int na)

{

	return of_bus_default_translate(addr + 1, offset, na - 1);

}



static unsigned int of_bus_isa_get_flags(const __be32 *addr)

{

	unsigned int flags = 0;
@@ -378,7 +369,7 @@ static struct of_bus of_busses[] = { 
		.match = of_bus_pci_match,

		.count_cells = of_bus_pci_count_cells,

		.map = of_bus_pci_map,

		.translate = of_bus_pci_translate,

		.translate = of_bus_default_flags_translate,

		.has_flags = true,

		.get_flags = of_bus_pci_get_flags,

	},
@@ -390,7 +381,7 @@ static struct of_bus of_busses[] = { 
		.match = of_bus_isa_match,

		.count_cells = of_bus_isa_count_cells,

		.map = of_bus_isa_map,

		.translate = of_bus_isa_translate,

		.translate = of_bus_default_flags_translate,

		.has_flags = true,

		.get_flags = of_bus_isa_get_flags,

	},