Commit 3ef79cd1 authored by Hugo Villeneuve's avatar Hugo Villeneuve Committed by Greg Kroah-Hartman
Browse files

serial: sc16is7xx: set safe default SPI clock frequency 



15 MHz is supported only by 76x variants.

If the SPI clock frequency is not specified, use a safe default clock value
of 4 MHz that is supported by all variants.

Also use HZ_PER_MHZ macro to improve readability.

Fixes: 2c837a8a ("sc16is7xx: spi interface is added")
Cc:  <stable@vger.kernel.org>
Signed-off-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20231221231823.2327894-4-hugo@hugovil.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6d710b76

drivers/tty/serial/sc16is7xx.c

+2 −1
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
#include <linux/tty_flip.h>

#include <linux/spi/spi.h>

#include <linux/uaccess.h>

#include <linux/units.h>

#include <uapi/linux/sched/types.h>



#define SC16IS7XX_NAME			"sc16is7xx"
@@ -1738,7 +1739,7 @@ static int sc16is7xx_spi_probe(struct spi_device *spi) 
		return dev_err_probe(&spi->dev, -EINVAL, "Unsupported SPI mode\n");



	spi->mode		= spi->mode ? : SPI_MODE_0;

	spi->max_speed_hz	= spi->max_speed_hz ? : 15000000;

	spi->max_speed_hz	= spi->max_speed_hz ? : 4 * HZ_PER_MHZ;

	ret = spi_setup(spi);

	if (ret)

		return ret;