Unverified Commit 3efe2ace authored by Lucas Stach's avatar Lucas Stach Committed by Robert Foss
Browse files

drm/bridge: analogix_dp: move basic controller init into runtime PM 



Make sure the controller is in a basic working state after runtime
resume. Keep the analog function enable in the mode set path as this
enables parts of the PHY that are only required to be powered when
there is a data stream being sent out.

Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240619182200.3752465-8-l.stach@pengutronix.de
parent 73f61390

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

+5 −9
Original line number Diff line number Diff line
@@ -41,10 +41,8 @@ struct bridge_init { 
	struct device_node *node;

};



static int analogix_dp_init_dp(struct analogix_dp_device *dp)

static void analogix_dp_init_dp(struct analogix_dp_device *dp)

{

	int ret;



	analogix_dp_reset(dp);



	analogix_dp_swreset(dp);
@@ -56,13 +54,9 @@ static int analogix_dp_init_dp(struct analogix_dp_device *dp) 
	analogix_dp_enable_sw_function(dp);



	analogix_dp_config_interrupt(dp);

	ret = analogix_dp_init_analog_func(dp);

	if (ret)

		return ret;



	analogix_dp_init_hpd(dp);

	analogix_dp_init_aux(dp);

	return 0;

}



static int analogix_dp_detect_hpd(struct analogix_dp_device *dp)
@@ -1251,9 +1245,9 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp) 


	pm_runtime_get_sync(dp->dev);



	ret = analogix_dp_init_dp(dp);

	ret = analogix_dp_init_analog_func(dp);

	if (ret)

		goto out_dp_init;

		return ret;



	/*

	 * According to DP spec v1.3 chap 3.5.1.2 Link Training,
@@ -1718,6 +1712,8 @@ int analogix_dp_resume(struct analogix_dp_device *dp) 


	phy_power_on(dp->phy);



	analogix_dp_init_dp(dp);



	return 0;

}

EXPORT_SYMBOL_GPL(analogix_dp_resume);