Commit 3f292517 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Kees Cook
Browse files

lib/prime_numbers: KUnit test should not select PRIME_NUMBERS 



Enabling a (modular) test should not silently enable additional kernel
functionality, as that may increase the attack vector of a product.

Fix this by making PRIME_NUMBERS_KUNIT_TEST depend on PRIME_NUMBERS
instead of selecting it.

After this, one can safely enable CONFIG_KUNIT_ALL_TESTS=m to build
modules for all appropriate tests for ones system, without pulling in
extra unwanted functionality, while still allowing a tester to manually
enable PRIME_NUMBERS and this test suite on a system where PRIME_NUMBERS
is not enabled by default.  Resurrect CONFIG_PRIME_NUMBERS=m in
tools/testing/selftests/lib/config for the latter use case.

Fixes: 313b38a6 ("lib/prime_numbers: convert self-test to KUnit")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Acked-by: default avatarTamir Duberstein <tamird@gmail.com>
Link: https://lore.kernel.org/r/40f8a40eef4930d3ac9febd205bc171eb04e171c.1744641237.git.geert@linux-m68k.org


Signed-off-by: default avatarKees Cook <kees@kernel.org>
parent 9b044614

lib/Kconfig.debug

+1 −1
Original line number Diff line number Diff line
@@ -3290,7 +3290,7 @@ config GCD_KUNIT_TEST 
config PRIME_NUMBERS_KUNIT_TEST

	tristate "Prime number generator test" if !KUNIT_ALL_TESTS

	depends on KUNIT

	select PRIME_NUMBERS

	depends on PRIME_NUMBERS

	default KUNIT_ALL_TESTS

	help

	  This option enables the KUnit test suite for the {is,next}_prime_number

tools/testing/selftests/lib/config

+1 −0
Original line number Diff line number Diff line 
CONFIG_TEST_BITMAP=m

CONFIG_PRIME_NUMBERS=m

CONFIG_TEST_BITOPS=m