Commit 3f3fc58d authored by Paolo Bonzini's avatar Paolo Bonzini Committed by Sean Christopherson
Browse files

KVM: x86: Move Src2Shift up one bit (use bits 36:32 for Src2 in the emulator) 



An irresistible microoptimization (changing accesses to Src2 to just an
AND :)) that also frees a bit for AVX in the low flags word.  This makes
it closer to SSE since both of them can access XMM registers, pointlessly
shaving another clock cycle or two (maybe).

No functional change intended.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Reviewed-by: default avatarChang S. Bae <chang.seok.bae@intel.com>
Link: https://patch.msgid.link/20251114003633.60689-3-pbonzini@redhat.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent c57d9baf

arch/x86/kvm/emulate.c

+2 −1
Original line number Diff line number Diff line
@@ -147,7 +147,7 @@ 
#define PageTable   (1 << 29)   /* instruction used to write page table */

#define NotImpl     (1 << 30)   /* instruction is not implemented */

/* Source 2 operand type */

#define Src2Shift   (31)

#define Src2Shift   (32)       /* bits 32-36 */

#define Src2None    (OpNone << Src2Shift)

#define Src2Mem     (OpMem << Src2Shift)

#define Src2CL      (OpCL << Src2Shift)
@@ -161,6 +161,7 @@ 
#define Src2FS      (OpFS << Src2Shift)

#define Src2GS      (OpGS << Src2Shift)

#define Src2Mask    (OpMask << Src2Shift)

/* free: 37-39 */

#define Mmx         ((u64)1 << 40)  /* MMX Vector instruction */

#define AlignMask   ((u64)7 << 41)

#define Aligned     ((u64)1 << 41)  /* Explicitly aligned (e.g. MOVDQA) */