Commit 3f81cf54 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi_glink: rework quirks implementation 



In preparation to adding more quirks, extract quirks to the static
variables and reference them through match->data. Otherwise adding
more quirks will add the table really cumbersome.

Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240329-qcom-ucsi-fixes-v2-8-0f5d37ed04db@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 16cad519

drivers/usb/typec/ucsi/ucsi_glink.c

+8 −6
Original line number Diff line number Diff line
@@ -311,12 +311,14 @@ static void pmic_glink_ucsi_destroy(void *data) 
	mutex_unlock(&ucsi->lock);

}



static unsigned long quirk_sc8180x = UCSI_NO_PARTNER_PDOS;



static const struct of_device_id pmic_glink_ucsi_of_quirks[] = {

	{ .compatible = "qcom,qcm6490-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },

	{ .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },

	{ .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },

	{ .compatible = "qcom,sm8350-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },

	{ .compatible = "qcom,sm8550-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },

	{ .compatible = "qcom,qcm6490-pmic-glink", .data = &quirk_sc8180x, },

	{ .compatible = "qcom,sc8180x-pmic-glink", .data = &quirk_sc8180x, },

	{ .compatible = "qcom,sc8280xp-pmic-glink", .data = &quirk_sc8180x, },

	{ .compatible = "qcom,sm8350-pmic-glink", .data = &quirk_sc8180x, },

	{ .compatible = "qcom,sm8550-pmic-glink", .data = &quirk_sc8180x, },

	{}

};
@@ -354,7 +356,7 @@ static int pmic_glink_ucsi_probe(struct auxiliary_device *adev, 


	match = of_match_device(pmic_glink_ucsi_of_quirks, dev->parent);

	if (match)

		ucsi->ucsi->quirks = (unsigned long)match->data;

		ucsi->ucsi->quirks = *(unsigned long *)match->data;



	ucsi_set_drvdata(ucsi->ucsi, ucsi);