Commit 3f8aa0b8 authored by Miri Korenblit's avatar Miri Korenblit Committed by Johannes Berg
Browse files

wifi: iwlwifi: fw: avoid using an uninitialized variable 



iwl_fwrt_read_err_table can return true also when it failed to read
the memory. In this case, err_id argument is not initialized,
but the callers are still using it.

Simply initialize it to 0. If the error table was read successfully it'll
be overridden.

Fixes: 43e0b2ad ("wifi: iwlwifi: fw: add an error table status getter")
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Link: https://patch.msgid.link/20250209143303.37cdbba4eb56.I95fe9bd95303b8179f946766558a9f15f4fe254c@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 7774e392

drivers/net/wireless/intel/iwlwifi/fw/dump.c

+3 −0
Original line number Diff line number Diff line
@@ -540,6 +540,9 @@ bool iwl_fwrt_read_err_table(struct iwl_trans *trans, u32 base, u32 *err_id) 
	} err_info = {};

	int ret;



	if (err_id)

		*err_id = 0;



	if (!base)

		return false;