Commit 3f96f545 authored by Alex Hung's avatar Alex Hung Committed by Alex Deucher
Browse files

drm/amd/display: Fix possible overflow in integer multiplication 



[WHAT & HOW]
Integer multiplies integer may overflow in context that expects an
expression of unsigned long long (64 bits). This can be fixed by casting
integer to unsigned long long to force 64 bits results.

This fixes 2 OVERFLOW_BEFORE_WIDEN issues reported by Coverity.

Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Reviewed-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent d5022deb

drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource_helpers.c

+2 −2
Original line number Diff line number Diff line
@@ -663,7 +663,7 @@ bool dcn32_subvp_drr_admissable(struct dc *dc, struct dc_state *context) 


				subvp_disallow |= disallow_subvp_in_active_plus_blank(pipe);

				refresh_rate = (pipe->stream->timing.pix_clk_100hz * (uint64_t)100 +

					pipe->stream->timing.v_total * pipe->stream->timing.h_total - (uint64_t)1);

					pipe->stream->timing.v_total * (unsigned long long)pipe->stream->timing.h_total - (uint64_t)1);

				refresh_rate = div_u64(refresh_rate, pipe->stream->timing.v_total);

				refresh_rate = div_u64(refresh_rate, pipe->stream->timing.h_total);

			}
@@ -724,7 +724,7 @@ bool dcn32_subvp_vblank_admissable(struct dc *dc, struct dc_state *context, int 


				subvp_disallow |= disallow_subvp_in_active_plus_blank(pipe);

				refresh_rate = (pipe->stream->timing.pix_clk_100hz * (uint64_t)100 +

					pipe->stream->timing.v_total * pipe->stream->timing.h_total - (uint64_t)1);

					pipe->stream->timing.v_total * (unsigned long long)pipe->stream->timing.h_total - (uint64_t)1);

				refresh_rate = div_u64(refresh_rate, pipe->stream->timing.v_total);

				refresh_rate = div_u64(refresh_rate, pipe->stream->timing.h_total);

			}