Commit 3fcc2339 authored Sep 04, 2024 by Miguel Ojeda

rust: enable `clippy::ignored_unit_patterns` lint

In Rust 1.73.0, Clippy introduced the `ignored_unit_patterns` lint [1]:

> Matching with `()` explicitly instead of `_` outlines the fact that
> the pattern contains no data. Also it would detect a type change
> that `_` would ignore.

There is only a single case that requires a change:

    error: matching over `()` is more explicit
       --> rust/kernel/types.rs:176:45
        |
    176 |         ScopeGuard::new_with_data((), move |_| cleanup())
        |                                             ^ help: use `()` instead of `_`: `()`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
        = note: requested on the command line with `-D clippy::ignored-unit-patterns`

Thus clean it up and enable the lint -- no functional change intended.

Link: https://rust-lang.github.io/rust-clippy/master/index.html#/ignored_unit_patterns

 [1]
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Tested-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20240904204347.168520-8-ojeda@kernel.org


Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

parent 23f42dc0

Makefile

+1 −0

Original line number	Diff line number	Diff line
		@@ -453,6 +453,7 @@ export rust_common_flags := --edition=2021 \
		-Wunreachable_pub \
		-Wclippy::all \
		-Wclippy::dbg_macro \
		-Wclippy::ignored_unit_patterns \
		-Wclippy::mut_mut \
		-Wclippy::needless_bitwise_bool \
		-Wclippy::needless_continue \

rust/kernel/types.rs

+1 −1

Original line number	Diff line number	Diff line
		@@ -225,7 +225,7 @@ pub fn dismiss(mut self) -> T {
		impl ScopeGuard<(), fn(())> {
		/// Creates a new guarded object with the given cleanup function.
		pub fn new(cleanup: impl FnOnce()) -> ScopeGuard<(), impl FnOnce(())> {
		ScopeGuard::new_with_data((), move \|_\| cleanup())
		ScopeGuard::new_with_data((), move \|()\| cleanup())
		}
		}