Commit 3fe62f7b authored by Lucas De Marchi's avatar Lucas De Marchi
Browse files

drm/xe: Mark reserved engines in snapshot 



When printing <debufs>/gt*/hw_engines, it's useful to mark
what engines are reserved so it doesn't mislead developers
while debugging.

Cc: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240906205609.3131330-1-lucas.demarchi@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent ceb29504

drivers/gpu/drm/xe/xe_hw_engine.c

+3 −0
Original line number Diff line number Diff line
@@ -903,6 +903,7 @@ xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe) 
	snapshot->forcewake.ref = xe_force_wake_ref(gt_to_fw(hwe->gt),

						    hwe->domain);

	snapshot->mmio_base = hwe->mmio_base;

	snapshot->kernel_reserved = xe_hw_engine_is_reserved(hwe);



	/* no more VF accessible data below this point */

	if (IS_SRIOV_VF(gt_to_xe(hwe->gt)))
@@ -1025,6 +1026,8 @@ void xe_hw_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot, 
		   snapshot->logical_instance);

	drm_printf(p, "\tForcewake: domain 0x%x, ref %d\n",

		   snapshot->forcewake.domain, snapshot->forcewake.ref);

	drm_printf(p, "\tReserved: %s\n",

		   str_yes_no(snapshot->kernel_reserved));

	drm_printf(p, "\tHWSTAM: 0x%08x\n", snapshot->reg.ring_hwstam);

	drm_printf(p, "\tRING_HWS_PGA: 0x%08x\n", snapshot->reg.ring_hws_pga);

	drm_printf(p, "\tRING_EXECLIST_STATUS: 0x%016llx\n",

drivers/gpu/drm/xe/xe_hw_engine_types.h

+2 −0
Original line number Diff line number Diff line
@@ -173,6 +173,8 @@ struct xe_hw_engine_snapshot { 
	} forcewake;

	/** @mmio_base: MMIO base address of this hw engine*/

	u32 mmio_base;

	/** @kernel_reserved: Engine reserved, can't be used by userspace */

	bool kernel_reserved;

	/** @reg: Useful MMIO register snapshot */

	struct {

		/** @reg.ring_execlist_status: RING_EXECLIST_STATUS */