Unverified Commit 3ff84e3d authored by Sascha Hauer's avatar Sascha Hauer Committed by Mark Brown
Browse files

ASoC: fsl_micfil: drop fsl_micfil_set_mclk_rate() 



All that the .set_sysclk hook in the micfil driver does is to pass
the sysclk frequency to fsl_micfil_set_mclk_rate(). This function
expects the sample rate as argument though, not any kind of sysclk
frequency. The resulting rate setting of the clock is overwritten
in hw_params anyway, so drop this altogether.

Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Acked-by: default avatarShengjiu Wang <shengjiu.wang@gmail.com>
Link: https://lore.kernel.org/r/20220414162249.3934543-4-s.hauer@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 384672e3

sound/soc/fsl/fsl_micfil.c

+0 −20
Original line number Diff line number Diff line
@@ -358,30 +358,10 @@ static int fsl_micfil_hw_params(struct snd_pcm_substream *substream, 
	return 0;

}



static int fsl_micfil_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,

				     unsigned int freq, int dir)

{

	struct fsl_micfil *micfil = snd_soc_dai_get_drvdata(dai);

	struct device *dev = &micfil->pdev->dev;



	int ret;



	if (!freq)

		return 0;



	ret = fsl_micfil_set_mclk_rate(micfil, freq);

	if (ret < 0)

		dev_err(dev, "failed to set mclk[%lu] to rate %u\n",

			clk_get_rate(micfil->mclk), freq);



	return ret;

}



static const struct snd_soc_dai_ops fsl_micfil_dai_ops = {

	.startup = fsl_micfil_startup,

	.trigger = fsl_micfil_trigger,

	.hw_params = fsl_micfil_hw_params,

	.set_sysclk = fsl_micfil_set_dai_sysclk,

};



static int fsl_micfil_dai_probe(struct snd_soc_dai *cpu_dai)