Commit 4106eb9b authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: make btrfs_should_delete_dir_index() return a bool instead 



There's no need to return errors and we currently return 1 in case the
index should be deleted and 0 otherwise, so change the return type from
int to bool as this is a boolean function and it's more clear this way.

Reviewed-by: default avatarBoris Burkov <boris@bur.io>
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent adc1ef55

fs/btrfs/delayed-inode.c

+3 −4
Original line number Diff line number Diff line
@@ -1734,17 +1734,16 @@ void btrfs_readdir_put_delayed_items(struct btrfs_inode *inode, 
	downgrade_write(&inode->vfs_inode.i_rwsem);

}



int btrfs_should_delete_dir_index(const struct list_head *del_list,

				  u64 index)

bool btrfs_should_delete_dir_index(const struct list_head *del_list, u64 index)

{

	struct btrfs_delayed_item *curr;

	int ret = 0;

	bool ret = false;



	list_for_each_entry(curr, del_list, readdir_list) {

		if (curr->index > index)

			break;

		if (curr->index == index) {

			ret = 1;

			ret = true;

			break;

		}

	}

fs/btrfs/delayed-inode.h

+1 −2
Original line number Diff line number Diff line
@@ -150,8 +150,7 @@ bool btrfs_readdir_get_delayed_items(struct btrfs_inode *inode, 
void btrfs_readdir_put_delayed_items(struct btrfs_inode *inode,

				     struct list_head *ins_list,

				     struct list_head *del_list);

int btrfs_should_delete_dir_index(const struct list_head *del_list,

				  u64 index);

bool btrfs_should_delete_dir_index(const struct list_head *del_list, u64 index);

int btrfs_readdir_delayed_dir_index(struct dir_context *ctx,

				    const struct list_head *ins_list);