Commit 4166204d authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

net: tap: Remove generic .ndo_get_stats64 



Commit 3e2f544d ("net: get stats64 if device if driver is
configured") moved the callback to dev_get_tstats64() to net core, so,
unless the driver is doing some custom stats collection, it does not
need to set .ndo_get_stats64.

Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
function pointer.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarWillem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20240304183810.1474883-2-leitao@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 46f480ec

drivers/net/tun.c

+0 −1
Original line number Diff line number Diff line
@@ -1338,7 +1338,6 @@ static const struct net_device_ops tap_netdev_ops = { 
	.ndo_select_queue	= tun_select_queue,

	.ndo_features_check	= passthru_features_check,

	.ndo_set_rx_headroom	= tun_set_headroom,

	.ndo_get_stats64	= dev_get_tstats64,

	.ndo_bpf		= tun_xdp,

	.ndo_xdp_xmit		= tun_xdp_xmit,

	.ndo_change_carrier	= tun_net_change_carrier,