Commit 41b4b11d authored by Jessica Zhang's avatar Jessica Zhang Committed by Dmitry Baryshkov
Browse files

drm: Add valid clones check 



Check that all encoders attached to a given CRTC are valid
possible_clones of each other.

Signed-off-by: default avatarJessica Zhang <quic_jesszhan@quicinc.com>
Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241216-concurrent-wb-v4-3-fe220297a7f0@quicinc.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 5a6e8c36

drivers/gpu/drm/drm_atomic_helper.c

+28 −0
Original line number Diff line number Diff line
@@ -574,6 +574,30 @@ mode_valid(struct drm_atomic_state *state) 
	return 0;

}



static int drm_atomic_check_valid_clones(struct drm_atomic_state *state,

					 struct drm_crtc *crtc)

{

	struct drm_encoder *drm_enc;

	struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state,

									  crtc);



	drm_for_each_encoder_mask(drm_enc, crtc->dev, crtc_state->encoder_mask) {

		if (!drm_enc->possible_clones) {

			DRM_DEBUG("enc%d possible_clones is 0\n", drm_enc->base.id);

			continue;

		}



		if ((crtc_state->encoder_mask & drm_enc->possible_clones) !=

		    crtc_state->encoder_mask) {

			DRM_DEBUG("crtc%d failed valid clone check for mask 0x%x\n",

				  crtc->base.id, crtc_state->encoder_mask);

			return -EINVAL;

		}

	}



	return 0;

}



/**

 * drm_atomic_helper_check_modeset - validate state object for modeset changes

 * @dev: DRM device
@@ -745,6 +769,10 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, 
		ret = drm_atomic_add_affected_planes(state, crtc);

		if (ret != 0)

			return ret;



		ret = drm_atomic_check_valid_clones(state, crtc);

		if (ret != 0)

			return ret;

	}



	/*