Commit 41c831bb authored by Justin Tee's avatar Justin Tee Committed by Martin K. Petersen
Browse files

scsi: lpfc: Introduce LOG_NODE_VERBOSE messaging flag 



The preexisting LOG_NODE message flag frequently spams a subset of the same
log messages during normal FC driver operations.  When analyzing driver
logs, this sometimes leads to difficulty in troubleshooting.

Because LOG_IP log message flag is unused, convert it to a new
LOG_NODE_VERBOSE flag.  The LOG_NODE_VERBOSE shall specifically be used for
diagnosing issues that require precise ndlp tracking detail.

Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20231009161812.97232-6-justintee8345@gmail.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a3c3c0a8

drivers/scsi/lpfc/lpfc_hbadisc.c

+4 −4
Original line number Diff line number Diff line
@@ -5653,7 +5653,7 @@ __lpfc_findnode_did(struct lpfc_vport *vport, uint32_t did) 
				 ((uint32_t)ndlp->nlp_xri << 16) |

				 ((uint32_t)ndlp->nlp_type << 8)

				 );

			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,

			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE_VERBOSE,

					 "0929 FIND node DID "

					 "Data: x%px x%x x%x x%x x%x x%px\n",

					 ndlp, ndlp->nlp_DID,
@@ -5700,8 +5700,8 @@ lpfc_findnode_mapped(struct lpfc_vport *vport) 
				 ((uint32_t)ndlp->nlp_type << 8) |

				 ((uint32_t)ndlp->nlp_rpi & 0xff));

			spin_unlock_irqrestore(shost->host_lock, iflags);

			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,

					 "2025 FIND node DID "

			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE_VERBOSE,

					 "2025 FIND node DID MAPPED "

					 "Data: x%px x%x x%x x%x x%px\n",

					 ndlp, ndlp->nlp_DID,

					 ndlp->nlp_flag, data1,
@@ -6467,7 +6467,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param) 


	list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {

		if (filter(ndlp, param)) {

			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,

			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE_VERBOSE,

					 "3185 FIND node filter %ps DID "

					 "ndlp x%px did x%x flg x%x st x%x "

					 "xri x%x type x%x rpi x%x\n",

drivers/scsi/lpfc/lpfc_logmsg.h

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ 
#define LOG_MBOX	0x00000004	/* Mailbox events */

#define LOG_INIT	0x00000008	/* Initialization events */

#define LOG_LINK_EVENT	0x00000010	/* Link events */

#define LOG_IP		0x00000020	/* IP traffic history */

#define LOG_NODE_VERBOSE 0x00000020	/* Node verbose events */

#define LOG_FCP		0x00000040	/* FCP traffic history */

#define LOG_NODE	0x00000080	/* Node table events */

#define LOG_TEMP	0x00000100	/* Temperature sensor events */