Commit 41d826c8 authored by Yu-Chun Lin's avatar Yu-Chun Lin Committed by Keith Busch
Browse files

nvmet: replace kmalloc + memset with kzalloc for data allocation 



cocci warnings: (new ones prefixed by >>)
>> drivers/nvme/target/pr.c:831:8-15: WARNING: kzalloc should be used for data, instead of kmalloc/memset

The pattern of using 'kmalloc' followed by 'memset' is replaced with
'kzalloc', which is functionally equivalent to 'kmalloc' + 'memset',
but more efficient. 'kzalloc' automatically zeroes the allocated
memory, making it a faster and more streamlined solution.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411301434.LEckbcWx-lkp@intel.com/


Reviewed-by: default avatarKuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarYu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 88c23a32

drivers/nvme/target/pr.c

+1 −2
Original line number Diff line number Diff line
@@ -828,12 +828,11 @@ static void nvmet_execute_pr_report(struct nvmet_req *req) 
		goto out;

	}



	data = kmalloc(num_bytes, GFP_KERNEL);

	data = kzalloc(num_bytes, GFP_KERNEL);

	if (!data) {

		status = NVME_SC_INTERNAL;

		goto out;

	}

	memset(data, 0, num_bytes);

	data->gen = cpu_to_le32(atomic_read(&pr->generation));

	data->ptpls = 0;

	ctrl_eds = data->regctl_eds;