Commit 422b5233 authored by Frank Wunderlich's avatar Frank Wunderlich Committed by Jakub Kicinski
Browse files

net: pcs: pcs-mtk-lynxi: fix bpi-r3 serdes configuration 



Commit 8871389d introduces common pcs dts properties which writes
rx=normal,tx=normal polarity to register SGMSYS_QPHY_WRAP_CTRL of switch.
This is initialized with tx-bit set and so change inverts polarity
compared to before.

It looks like mt7531 has tx polarity inverted in hardware and set tx-bit
by default to restore the normal polarity.

The MT7531 datasheet quite clearly states:
Register 000050EC QPHY_WRAP_CTRL -- QPHY wrapper control
Reset value: 0x00000501

BIT 1 RX_BIT_POLARITY -- RX bit polarity control
 1'b0: normal
 1'b1: inverted

BIT 0 TX_BIT_POLARITY -- TX bit polarity control (TX default inversed
in MT7531)
 1'b0: normal
 1'b1: inverted

Till this patch the register write was only called when mediatek,pnswap
property was set which cannot be done for switch because the fw-node param
was always NULL from switch driver in the mtk_pcs_lynxi_create call.

Do not configure switch side like it's done before.

Fixes: 8871389d ("net: pcs: pcs-mtk-lynxi: deprecate "mediatek,pnswap"")
Signed-off-by: default avatarFrank Wunderlich <frank-w@public-files.de>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20260526153239.30194-1-linux@fw-web.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2412591c

drivers/net/pcs/pcs-mtk-lynxi.c

+3 −0
Original line number Diff line number Diff line
@@ -129,6 +129,9 @@ static int mtk_pcs_config_polarity(struct mtk_pcs_lynxi *mpcs, 
	unsigned int val = 0;

	int ret;



	if (!fwnode)

		return 0;



	if (fwnode_property_read_bool(fwnode, "mediatek,pnswap"))

		default_pol = PHY_POL_INVERT;