Commit 42343207 authored by kernel test robot's avatar kernel test robot Committed by Greg Kroah-Hartman
Browse files

USB: gadget: f_fs: fix memdup_user.cocci warnings 



drivers/usb/gadget/function/f_fs.c:3829:8-15: WARNING opportunity for memdup_user

 Use memdup_user rather than duplicating its implementation
 This is a little bit restricted to reduce false positives

Generated by: scripts/coccinelle/api/memdup_user.cocci

Fixes: 8704fd73 ("USB: gadget: f_fs: remove likely/unlikely")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarkernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20210308070951.GA83949@8a16bdd473dc


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f2b6ebf6

drivers/usb/gadget/function/f_fs.c

+3 −8
Original line number Diff line number Diff line
@@ -3827,14 +3827,9 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len) 
	if (!len)

		return NULL;



	data = kmalloc(len, GFP_KERNEL);

	if (!data)

		return ERR_PTR(-ENOMEM);



	if (copy_from_user(data, buf, len)) {

		kfree(data);

		return ERR_PTR(-EFAULT);

	}

	data = memdup_user(buf, len);

	if (IS_ERR(data))

		return ERR_PTR(PTR_ERR(data));



	pr_vdebug("Buffer from user space:\n");

	ffs_dump_mem("", data, len);