Commit 42374303 authored by Takashi Sakamoto's avatar Takashi Sakamoto
Browse files

firewire: ohci: obsolete OHCI_PARAM_DEBUG_BUSRESETS from debug module parameter 

The OHCI_PARAM_DEBUG_BUSRESETS bit of debug module parameter was added at
a commit a007bb85 ("firewire: fw-ohci: conditionally log busReset
interrupts").

At the former commit, the bit becomes less meaningful, just to skip
logging.

This commit obsoletes it.

Link: https://lore.kernel.org/r/20240501073238.72769-3-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
parent 0d12f095

drivers/firewire/ohci.c

+1 −8
Original line number Diff line number Diff line
@@ -394,7 +394,6 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default = 0" 
#define OHCI_PARAM_DEBUG_AT_AR		1

#define OHCI_PARAM_DEBUG_SELFIDS	2

#define OHCI_PARAM_DEBUG_IRQS		4

#define OHCI_PARAM_DEBUG_BUSRESETS	8



static int param_debug;

module_param_named(debug, param_debug, int, 0644);
@@ -402,7 +401,6 @@ MODULE_PARM_DESC(debug, "Verbose logging (default = 0" 
	", AT/AR events = "	__stringify(OHCI_PARAM_DEBUG_AT_AR)

	", self-IDs = "		__stringify(OHCI_PARAM_DEBUG_SELFIDS)

	", IRQs = "		__stringify(OHCI_PARAM_DEBUG_IRQS)

	", busReset events = "	__stringify(OHCI_PARAM_DEBUG_BUSRESETS)

	", or a combination, or all = -1)");



static bool param_remote_dma;
@@ -411,12 +409,7 @@ MODULE_PARM_DESC(remote_dma, "Enable unfiltered remote DMA (default = N)"); 


static void log_irqs(struct fw_ohci *ohci, u32 evt)

{

	if (likely(!(param_debug &

			(OHCI_PARAM_DEBUG_IRQS | OHCI_PARAM_DEBUG_BUSRESETS))))

		return;



	if (!(param_debug & OHCI_PARAM_DEBUG_IRQS) &&

	    !(evt & OHCI1394_busReset))

	if (likely(!(param_debug & OHCI_PARAM_DEBUG_IRQS)))

		return;



	ohci_notice(ohci, "IRQ %08x%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s\n", evt,