Commit 425da330 authored by Vladimir Lypak's avatar Vladimir Lypak Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: Disable scaling for unsupported scaler types 



Scaling is not implemented for some type of scalers (QSEED2 and RGB) but
it was unintentionally re-enabled with change below. The remaining
condition in dpu_plane_atomic_check_pipe is not enough because it only
checks for length of scaler block (which is present). This patch adds a
additional check for setup_scaler operation.

Fixes: 8f150057 ("drm/msm/dpu: move scaling limitations out of the hw_catalog")
Signed-off-by: default avatarVladimir Lypak <vladimir.lypak@gmail.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/681918/
Link: https://lore.kernel.org/r/20251017-b4-dpu-fixes-v1-3-40ce5993eeb6@gmail.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 23ab0d62

drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

+1 −1
Original line number Diff line number Diff line
@@ -740,7 +740,7 @@ static int dpu_plane_atomic_check_pipe(struct dpu_plane *pdpu, 
	 * We already have verified scaling against platform limitations.

	 * Now check if the SSPP supports scaling at all.

	 */

	if (!sblk->scaler_blk.len &&

	if (!(sblk->scaler_blk.len && pipe->sspp->ops.setup_scaler) &&

	    ((drm_rect_width(&new_plane_state->src) >> 16 !=

	      drm_rect_width(&new_plane_state->dst)) ||

	     (drm_rect_height(&new_plane_state->src) >> 16 !=