Commit 435c20ee authored by Zichen Xie's avatar Zichen Xie Committed by Shuah Khan
Browse files

kunit: Fix potential null dereference in kunit_device_driver_test() 

kunit_kzalloc() may return a NULL pointer, dereferencing it without
NULL check may lead to NULL dereference.
Add a NULL check for test_state.

Link: https://lore.kernel.org/r/20241115054335.21673-1-zichenxie0106@gmail.com


Fixes: d03c720e ("kunit: Add APIs for managing devices")
Signed-off-by: default avatarZichen Xie <zichenxie0106@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent aadf9cb1

lib/kunit/kunit-test.c

+2 −0
Original line number Diff line number Diff line
@@ -805,6 +805,8 @@ static void kunit_device_driver_test(struct kunit *test) 
	struct device *test_device;

	struct driver_test_state *test_state = kunit_kzalloc(test, sizeof(*test_state), GFP_KERNEL);



	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, test_state);



	test->priv = test_state;

	test_driver = kunit_driver_create(test, "my_driver");