Unverified Commit 43b0b7ef authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Ilpo Järvinen
Browse files

platform/x86: panasonic-laptop: Fix sysfs group leak in error path 



The acpi_pcc_hotkey_add() error path leaks sysfs group pcc_attr_group
if platform_device_register_simple() fails for the "panasonic" platform
device.

Address this by making it call sysfs_remove_group() in that case for
the group in question.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/3398370.44csPzL39Z@rafael.j.wysocki


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 4b11f233

drivers/platform/x86/panasonic-laptop.c

+3 −1
Original line number Diff line number Diff line
@@ -1089,7 +1089,7 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device) 
			PLATFORM_DEVID_NONE, NULL, 0);

		if (IS_ERR(pcc->platform)) {

			result = PTR_ERR(pcc->platform);

			goto out_backlight;

			goto out_sysfs;

		}

		result = device_create_file(&pcc->platform->dev,

			&dev_attr_cdpower);
@@ -1105,6 +1105,8 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device) 


out_platform:

	platform_device_unregister(pcc->platform);

out_sysfs:

	sysfs_remove_group(&device->dev.kobj, &pcc_attr_group);

out_backlight:

	backlight_device_unregister(pcc->backlight);

out_input: