Commit 4430d02d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: lpc18xx-sct: Don't modify the cached period of other PWM outputs 



Even though the hardware only supports a single period for all PWM
outputs, modifying the other (disabled) outputs's period is strange and
wrong. Only the pwm core is supposed to update these values.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent b41ccc3b

drivers/pwm/pwm-lpc18xx-sct.c

+1 −3
Original line number Diff line number Diff line
@@ -194,7 +194,7 @@ static int lpc18xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, 
			      int duty_ns, int period_ns)

{

	struct lpc18xx_pwm_chip *lpc18xx_pwm = to_lpc18xx_pwm_chip(chip);

	int requested_events, i;

	int requested_events;



	if (period_ns < lpc18xx_pwm->min_period_ns ||

	    period_ns > lpc18xx_pwm->max_period_ns) {
@@ -223,8 +223,6 @@ static int lpc18xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, 
	if ((requested_events <= 2 && lpc18xx_pwm->period_ns != period_ns) ||

	    !lpc18xx_pwm->period_ns) {

		lpc18xx_pwm->period_ns = period_ns;

		for (i = 0; i < chip->npwm; i++)

			pwm_set_period(&chip->pwms[i], period_ns);

		lpc18xx_pwm_config_period(chip, period_ns);

	}