Unverified Commit 4439a2e9 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Mark Brown
Browse files

spi: bcmbca-hsspi: Fix missing pm_runtime_disable() 



The pm_runtime_disable() is missing in remove function, use
devm_pm_runtime_enable() to fix it. So the pm_runtime_disable() in
the probe error path can also be removed.

Fixes: a38a2233 ("spi: bcmbca-hsspi: Add driver for newer HSSPI controller")
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: default avatarWilliam Zhang <william.zhang@broadcom.com>
Link: https://patch.msgid.link/20240826124903.3429235-2-ruanjinjie@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2fe6102b

drivers/spi/spi-bcmbca-hsspi.c

+4 −4
Original line number Diff line number Diff line
@@ -539,12 +539,14 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev) 
			goto out_put_host;

	}



	pm_runtime_enable(&pdev->dev);

	ret = devm_pm_runtime_enable(&pdev->dev);

	if (ret)

		goto out_put_host;



	ret = sysfs_create_group(&pdev->dev.kobj, &bcmbca_hsspi_group);

	if (ret) {

		dev_err(&pdev->dev, "couldn't register sysfs group\n");

		goto out_pm_disable;

		goto out_put_host;

	}



	/* register and we are done */
@@ -558,8 +560,6 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev) 


out_sysgroup_disable:

	sysfs_remove_group(&pdev->dev.kobj, &bcmbca_hsspi_group);

out_pm_disable:

	pm_runtime_disable(&pdev->dev);

out_put_host:

	spi_controller_put(host);

out_disable_pll_clk: