Commit 44c5aa73 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Georgi Djakov
Browse files

interconnect: icc-clk: check return values of devm_kasprintf() 



devm_kasprintf() can fail and return NULL, add missing return value
checks.

Fixes: 0ac2a08f ("interconnect: add clk-based icc provider support")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241202165723.17292-1-brgl@bgdev.pl


Signed-off-by: default avatarGeorgi Djakov <djakov@kernel.org>
parent 00a973e0

drivers/interconnect/icc-clk.c

+10 −0
Original line number Diff line number Diff line
@@ -116,6 +116,11 @@ struct icc_provider *icc_clk_register(struct device *dev, 
		}



		node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_master", data[i].name);

		if (!node->name) {

			ret = -ENOMEM;

			goto err;

		}



		node->data = &qp->clocks[i];

		icc_node_add(node, provider);

		/* link to the next node, slave */
@@ -129,6 +134,11 @@ struct icc_provider *icc_clk_register(struct device *dev, 
		}



		node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_slave", data[i].name);

		if (!node->name) {

			ret = -ENOMEM;

			goto err;

		}



		/* no data for slave node */

		icc_node_add(node, provider);

		onecell->nodes[j++] = node;