Commit 450a5639 authored by Oliver Upton's avatar Oliver Upton Committed by Paolo Bonzini
Browse files

KVM: stats: Fix value for KVM_STATS_UNIT_MAX for boolean stats 



commit 1b870fa5 ("kvm: stats: tell userspace which values are
boolean") added a new stat unit (boolean) but failed to raise
KVM_STATS_UNIT_MAX.

Fix by pointing UNIT_MAX at the new max value of UNIT_BOOLEAN.

Fixes: 1b870fa5 ("kvm: stats: tell userspace which values are boolean")
Reported-by: default avatarJanis Schoetterl-Glausch <scgl@linux.ibm.com>
Signed-off-by: default avatarOliver Upton <oupton@google.com>
Message-Id: <20220719125229.2934273-1-oupton@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 79629181

Documentation/virt/kvm/api.rst

+1 −1
Original line number Diff line number Diff line
@@ -5658,7 +5658,7 @@ by a string of size ``name_size``. 
	#define KVM_STATS_UNIT_SECONDS		(0x2 << KVM_STATS_UNIT_SHIFT)

	#define KVM_STATS_UNIT_CYCLES		(0x3 << KVM_STATS_UNIT_SHIFT)

	#define KVM_STATS_UNIT_BOOLEAN		(0x4 << KVM_STATS_UNIT_SHIFT)

	#define KVM_STATS_UNIT_MAX		KVM_STATS_UNIT_CYCLES

	#define KVM_STATS_UNIT_MAX		KVM_STATS_UNIT_BOOLEAN



	#define KVM_STATS_BASE_SHIFT		8

	#define KVM_STATS_BASE_MASK		(0xF << KVM_STATS_BASE_SHIFT)

include/uapi/linux/kvm.h

+1 −1
Original line number Diff line number Diff line
@@ -2084,7 +2084,7 @@ struct kvm_stats_header { 
#define KVM_STATS_UNIT_SECONDS		(0x2 << KVM_STATS_UNIT_SHIFT)

#define KVM_STATS_UNIT_CYCLES		(0x3 << KVM_STATS_UNIT_SHIFT)

#define KVM_STATS_UNIT_BOOLEAN		(0x4 << KVM_STATS_UNIT_SHIFT)

#define KVM_STATS_UNIT_MAX		KVM_STATS_UNIT_CYCLES

#define KVM_STATS_UNIT_MAX		KVM_STATS_UNIT_BOOLEAN



#define KVM_STATS_BASE_SHIFT		8

#define KVM_STATS_BASE_MASK		(0xF << KVM_STATS_BASE_SHIFT)