Commit 45b96d65 authored by Niklas Cassel's avatar Niklas Cassel
Browse files

ata: ahci: a hotplug capable port is an external port 



A hotplug capable port is an external port, so mark it as such.

We even say this ourselves in libata-scsi.c:
/* set scsi removable (RMB) bit per ata bit, or if the
 * AHCI port says it's external (Hotplug-capable, eSATA).
 */

This also matches the terminology used in AHCI 1.3.1
(the keyword to search for is "externally accessible").

Tested-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Tested-by: default avatarJian-Hong Pan <jhp@endlessos.org>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
parent f7131935

drivers/ata/ahci.c

+3 −2
Original line number Diff line number Diff line
@@ -1648,9 +1648,10 @@ static void ahci_mark_external_port(struct ata_port *ap) 
	void __iomem *port_mmio = ahci_port_base(ap);

	u32 tmp;



	/* mark esata ports */

	/* mark external ports (hotplug-capable, eSATA) */

	tmp = readl(port_mmio + PORT_CMD);

	if ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS))

	if (((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS)) ||

	    (tmp & PORT_CMD_HPCP))

		ap->pflags |= ATA_PFLAG_EXTERNAL;

}