Unverified Commit 45c9faf5 authored by Mateusz Guzik's avatar Mateusz Guzik Committed by Christian Brauner
Browse files

vfs: make evict() use smp_mb__after_spinlock instead of smp_mb 



It literally directly follows a spin_lock() call.

This whacks an explicit barrier on x86-64.

Signed-off-by: default avatarMateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20241113155103.4194099-1-mjguzik@gmail.com


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 2f4d4503

fs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -746,7 +746,7 @@ static void evict(struct inode *inode) 
	 * ___wait_var_event() either sees the bit cleared or

	 * waitqueue_active() check in wake_up_var() sees the waiter.

	 */

	smp_mb();

	smp_mb__after_spinlock();

	inode_wake_up_bit(inode, __I_NEW);

	BUG_ON(inode->i_state != (I_FREEING | I_CLEAR));

	spin_unlock(&inode->i_lock);