Commit 462baaf4 authored by Konrad Dybcio's avatar Konrad Dybcio Committed by Georgi Djakov
Browse files

dt-bindings: interconnect: qcom: Fix and separate out MSM8939



Separate out MSM8939 icc bindings from the common file and fix the
clocks description by removing the wrong internal RPM bus clock
representation that we've been carrying for years.

This was the final one, so also retire the shared file.

Signed-off-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230721-topic-icc_bindings-v2-5-e33d5acbf3bd@linaro.org


Signed-off-by: default avatarGeorgi Djakov <djakov@kernel.org>
parent d03374a6
Loading
Loading
Loading
Loading
+74 −0
Original line number Diff line number Diff line
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/interconnect/qcom,msm8939.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Qualcomm MSM8939 Network-On-Chip interconnect

maintainers:
  - Konrad Dybcio <konradybcio@kernel.org>

description: |
  The Qualcomm MSM8939 interconnect providers support adjusting the
  bandwidth requirements between the various NoC fabrics.

allOf:
  - $ref: qcom,rpm-common.yaml#

properties:
  compatible:
    enum:
      - qcom,msm8939-bimc
      - qcom,msm8939-pcnoc
      - qcom,msm8939-snoc

  reg:
    maxItems: 1

patternProperties:
  '^interconnect-[a-z0-9\-]+$':
    type: object
    $ref: qcom,rpm-common.yaml#
    description:
      The interconnect providers do not have a separate QoS register space,
      but share parent's space.

    allOf:
      - $ref: qcom,rpm-common.yaml#

    properties:
      compatible:
        const: qcom,msm8939-snoc-mm

    required:
      - compatible

    unevaluatedProperties: false

required:
  - compatible
  - reg

unevaluatedProperties: false

examples:
  - |
    #include <dt-bindings/clock/qcom,rpmcc.h>

    snoc: interconnect@580000 {
        compatible = "qcom,msm8939-snoc";
        reg = <0x00580000 0x14000>;
        #interconnect-cells = <1>;
    };

    bimc: interconnect@400000 {
        compatible = "qcom,msm8939-bimc";
        reg = <0x00400000 0x62000>;
        #interconnect-cells = <1>;

          snoc_mm: interconnect-snoc {
              compatible = "qcom,msm8939-snoc-mm";
              #interconnect-cells = <1>;
          };
    };
+0 −49
Original line number Diff line number Diff line
@@ -23,9 +23,6 @@ properties:
      - qcom,msm8916-bimc
      - qcom,msm8916-pcnoc
      - qcom,msm8916-snoc
      - qcom,msm8939-bimc
      - qcom,msm8939-pcnoc
      - qcom,msm8939-snoc
      - qcom,qcs404-bimc
      - qcom,qcs404-pcnoc
      - qcom,qcs404-snoc
@@ -48,38 +45,6 @@ properties:
  power-domains:
    maxItems: 1

# Child node's properties
patternProperties:
  '^interconnect-[a-z0-9]+$':
    type: object
    additionalProperties: false
    description:
      snoc-mm is a child of snoc, sharing snoc's register address space.

    properties:
      compatible:
        enum:
          - qcom,msm8939-snoc-mm

      '#interconnect-cells':
        const: 1

      clock-names:
        items:
          - const: bus
          - const: bus_a

      clocks:
        items:
          - description: Bus Clock
          - description: Bus A Clock

    required:
      - compatible
      - '#interconnect-cells'
      - clock-names
      - clocks

required:
  - compatible
  - reg
@@ -98,9 +63,6 @@ allOf:
              - qcom,msm8916-bimc
              - qcom,msm8916-pcnoc
              - qcom,msm8916-snoc
              - qcom,msm8939-bimc
              - qcom,msm8939-pcnoc
              - qcom,msm8939-snoc
              - qcom,qcs404-bimc
              - qcom,qcs404-pcnoc
              - qcom,qcs404-snoc
@@ -117,17 +79,6 @@ allOf:
            - description: Bus Clock
            - description: Bus A Clock

  - if:
      not:
        properties:
          compatible:
            contains:
              enum:
                - qcom,msm8939-snoc
    then:
      patternProperties:
        '^interconnect-[a-z0-9]+$': false

examples:
  - |
      #include <dt-bindings/clock/qcom,rpmcc.h>