Unverified Commit 4665a0da authored by Andrey Vatoropin's avatar Andrey Vatoropin Committed by Konstantin Komarov
Browse files

fs/ntfs3: Drop redundant NULL check 



Static analysis shows that pointer "mi" cannot be NULL, since it is
pre-initialized above. A potential failure when mi equals NULL is
processed.

Remove the extra NULL check. It is meaningless and harms the readability
of the code, since before that the pointer is unconditionally
dereferenced.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarAndrey Vatoropin <a.vatoropin@crpt.ru>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent 0af2f6be

fs/ntfs3/fslog.c

+1 −1
Original line number Diff line number Diff line
@@ -3143,7 +3143,7 @@ static int do_action(struct ntfs_log *log, struct OPEN_ATTR_ENRTY *oe, 


			if (inode)

				iput(inode);

			else if (mi)

			else

				mi_put(mi);



			inode = inode_parent;