Commit 46df19a8 authored by Biju Das's avatar Biju Das Committed by David S. Miller
Browse files

net: dsa: rzn1_a5psw: Use of_get_available_child_by_name() 



Simplify a5psw_probe() by using of_get_available_child_by_name().

While at it, move of_node_put(mdio) inside the if block to avoid code
duplication.

Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8d3bbe43

drivers/net/dsa/rzn1_a5psw.c

+3 −5
Original line number Diff line number Diff line
@@ -1248,18 +1248,16 @@ static int a5psw_probe(struct platform_device *pdev) 
	if (ret)

		goto clk_disable;



	mdio = of_get_child_by_name(dev->of_node, "mdio");

	if (of_device_is_available(mdio)) {

	mdio = of_get_available_child_by_name(dev->of_node, "mdio");

	if (mdio) {

		ret = a5psw_probe_mdio(a5psw, mdio);

		if (ret) {

		of_node_put(mdio);

		if (ret) {

			dev_err(dev, "Failed to register MDIO: %d\n", ret);

			goto hclk_disable;

		}

	}



	of_node_put(mdio);



	ds = &a5psw->ds;

	ds->dev = dev;

	ds->num_ports = A5PSW_PORTS_NUM;