Commit 46e6acfe authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Jakub Kicinski
Browse files

net: phy: qca807x: Drop unnecessary and broken DT validation 



The check for "leds" and "gpio-controller" both being present is never
true because "leds" is a node, not a property. This could be fixed
with a check for child node, but there's really no need for the kernel
to validate a DT. Just continue ignoring the LEDs if GPIOs are present.

Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20240731201703.1842022-2-robh@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5fcf0801

drivers/net/phy/qcom/qca807x.c

+0 −10
Original line number Diff line number Diff line
@@ -733,16 +733,6 @@ static int qca807x_probe(struct phy_device *phydev) 
								     "qcom,dac-disable-bias-current-tweak");



#if IS_ENABLED(CONFIG_GPIOLIB)

	/* Make sure we don't have mixed leds node and gpio-controller

	 * to prevent registering leds and having gpio-controller usage

	 * conflicting with them.

	 */

	if (of_find_property(node, "leds", NULL) &&

	    of_find_property(node, "gpio-controller", NULL)) {

		phydev_err(phydev, "Invalid property detected. LEDs and gpio-controller are mutually exclusive.");

		return -EINVAL;

	}



	/* Do not register a GPIO controller unless flagged for it */

	if (of_property_read_bool(node, "gpio-controller")) {

		ret = qca807x_gpio(phydev);