Commit 46f99eeb authored by Mikko Perttunen's avatar Mikko Perttunen Committed by Thierry Reding
Browse files

drm/tegra: Don't call SET_APPLICATION_ID in VIC boot 



The application should be programming the application ID, not
the kernel, as there can be several options to choose from,
and setting the application ID multiple times can cause issues.

Signed-off-by: default avatarMikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent d12919bb

drivers/gpu/drm/tegra/vic.c

+0 −2
Original line number Diff line number Diff line
@@ -148,8 +148,6 @@ static int vic_boot(struct vic *vic) 
	hdr = vic->falcon.firmware.virt;

	fce_bin_data_offset = *(u32 *)(hdr + VIC_UCODE_FCE_DATA_OFFSET);



	falcon_execute_method(&vic->falcon, VIC_SET_APPLICATION_ID, 1);



	/* Old VIC firmware needs kernel help with setting up FCE microcode. */

	if (fce_bin_data_offset != 0x0 && fce_bin_data_offset != 0xa5a5a5a5) {

		hdr = vic->falcon.firmware.virt +

drivers/gpu/drm/tegra/vic.h

+0 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ 


/* VIC methods */



#define VIC_SET_APPLICATION_ID			0x00000200

#define VIC_SET_FCE_UCODE_SIZE			0x0000071C

#define VIC_SET_FCE_UCODE_OFFSET		0x0000072C