Commit 4710430a authored by Aric Cyr's avatar Aric Cyr Committed by Alex Deucher
Browse files

drm/amd/display: DCHUB underflow counter increasing in some scenarios 



[Why]
When unplugging a display, the underflow counter can be seen to
increase because PSTATE switch is allowed even when some planes are not
blanked.

[How]
Check that all planes are not active instead of all streams before
allowing PSTATE change.

Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAric Cyr <aric.cyr@amd.com>
Acked-by: default avatarSolomon Chiu <solomon.chiu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 592a6318

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c

+3 −1
Original line number Diff line number Diff line
@@ -252,6 +252,7 @@ static void dcn3_update_clocks(struct clk_mgr *clk_mgr_base, 
	bool force_reset = false;

	bool update_uclk = false;

	bool p_state_change_support;

	int total_plane_count;



	if (dc->work_arounds.skip_clock_update || !clk_mgr->smu_present)

		return;
@@ -292,7 +293,8 @@ static void dcn3_update_clocks(struct clk_mgr *clk_mgr_base, 
		clk_mgr_base->clks.socclk_khz = new_clocks->socclk_khz;



	clk_mgr_base->clks.prev_p_state_change_support = clk_mgr_base->clks.p_state_change_support;

	p_state_change_support = new_clocks->p_state_change_support || (display_count == 0);

	total_plane_count = clk_mgr_helper_get_active_plane_cnt(dc, context);

	p_state_change_support = new_clocks->p_state_change_support || (total_plane_count == 0);

	if (should_update_pstate_support(safe_to_lower, p_state_change_support, clk_mgr_base->clks.p_state_change_support)) {

		clk_mgr_base->clks.p_state_change_support = p_state_change_support;