Commit 47189579 authored by Adrian Hunter's avatar Adrian Hunter Committed by Alexandre Belloni
Browse files

i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked() 



IBI disable failures are not indicative of a software bug, so using
WARN_ON() is not appropriate.  Replace these warnings with dev_err().

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260113072702.16268-5-adrian.hunter@intel.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent f0775157

drivers/i3c/master.c

+5 −2
Original line number Diff line number Diff line
@@ -3150,8 +3150,11 @@ void i3c_dev_free_ibi_locked(struct i3c_dev_desc *dev) 
	if (!dev->ibi)

		return;



	if (WARN_ON(dev->ibi->enabled))

		WARN_ON(i3c_dev_disable_ibi_locked(dev));

	if (dev->ibi->enabled) {

		dev_err(&master->dev, "Freeing IBI that is still enabled\n");

		if (i3c_dev_disable_ibi_locked(dev))

			dev_err(&master->dev, "Failed to disable IBI before freeing\n");

	}



	master->ops->free_ibi(dev);