Commit 4784f3f9 authored by Mukesh Sisodiya's avatar Mukesh Sisodiya Committed by Johannes Berg
Browse files

wifi: iwlwifi: remove dead code in iwl_dump_ini_imr_get_size() 



Remove the check for the IMR debug data size which
leads to dead code.

Signed-off-by: default avatarMukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230531194630.58eec8d40729.Ifb7d64706eed45726db804f36e785283dff7adab@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9e694212

drivers/net/wireless/intel/iwlwifi/fw/dbg.c

+5 −7
Original line number Diff line number Diff line
@@ -2031,7 +2031,6 @@ static u32 
iwl_dump_ini_imr_get_size(struct iwl_fw_runtime *fwrt,

			  struct iwl_dump_ini_region_data *reg_data)

{

	u32 size = 0;

	u32 ranges = 0;

	u32 imr_enable = fwrt->trans->dbg.imr_data.imr_enable;

	u32 imr_size = fwrt->trans->dbg.imr_data.imr_size;
@@ -2041,17 +2040,16 @@ iwl_dump_ini_imr_get_size(struct iwl_fw_runtime *fwrt, 
		IWL_DEBUG_INFO(fwrt,

			       "WRT: Invalid imr data enable: %d, imr_size: %d, sram_size: %d\n",

			       imr_enable, imr_size, sram_size);

		return size;

		return 0;

	}

	size = imr_size;

	ranges = iwl_dump_ini_imr_ranges(fwrt, reg_data);

	if (!size && !ranges) {

		IWL_ERR(fwrt, "WRT: imr_size :=%d, ranges :=%d\n", size, ranges);

	if (!ranges) {

		IWL_ERR(fwrt, "WRT: ranges :=%d\n", ranges);

		return 0;

	}

	size += sizeof(struct iwl_fw_ini_error_dump) +

	imr_size += sizeof(struct iwl_fw_ini_error_dump) +

		ranges * sizeof(struct iwl_fw_ini_error_dump_range);

	return size;

	return imr_size;

}



/**