Commit 479c3304 authored by ZhangPeng's avatar ZhangPeng Committed by Andrew Morton
Browse files

mm/page_io: remove unneeded ClearPageUptodate() 

Patch series "Convert several functions in page_io.c to use a folio", v4.

Convert several functions in page_io.c to use a folio, which can remove
several implicit calls to compound_head().


This patch (of 10):

The VM_BUG_ON_FOLIO in swap_readpage() ensures that the page is already
!uptodate in __end_swap_bio_read() and sio_read_complete().  Just remove
unneeded ClearPageUptodate().

Link: https://lkml.kernel.org/r/20230721034451.16412-1-zhangpeng362@huawei.com
Link: https://lkml.kernel.org/r/20230721034451.16412-2-zhangpeng362@huawei.com


Signed-off-by: default avatarZhangPeng <zhangpeng362@huawei.com>
Suggested-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Nanyong Sun <sunnanyong@huawei.com>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 3c099a2b

mm/page_io.c

+0 −2
Original line number Diff line number Diff line
@@ -62,7 +62,6 @@ static void __end_swap_bio_read(struct bio *bio) 


	if (bio->bi_status) {

		SetPageError(page);

		ClearPageUptodate(page);

		pr_alert_ratelimited("Read-error on swap-device (%u:%u:%llu)\n",

				     MAJOR(bio_dev(bio)), MINOR(bio_dev(bio)),

				     (unsigned long long)bio->bi_iter.bi_sector);
@@ -417,7 +416,6 @@ static void sio_read_complete(struct kiocb *iocb, long ret) 
			struct page *page = sio->bvec[p].bv_page;



			SetPageError(page);

			ClearPageUptodate(page);

			unlock_page(page);

		}

		pr_alert_ratelimited("Read-error on swap-device\n");