Commit 487f9b3d authored by John Hubbard's avatar John Hubbard Committed by Miguel Ojeda
Browse files

rust: cpufreq: suppress clippy::double_parens in Policy doctest 

The kernel fmt! proc macro wraps each format argument as &(arg). Passing a
tuple such as (a, b) produces &((a, b)) after expansion. Clippy flags that
as double_parens, but it is a false positive fixed in Clippy 1.92 [1] [2].

Suppress the warning on the affected doctest function with a reason
attribute so it can be removed once the minimum toolchain moves past 1.92.

[ We may end up deciding to support per-version Clippy lints, in which
  case we will need [3].

  In the future, if [4] gets fixed, we may be able to use
  `Delimiter::None` as Gary suggested in [5].

  Link: https://lore.kernel.org/rust-for-linux/20260307170929.153892-1-ojeda@kernel.org/ [3]
  Link: https://github.com/rust-lang/rust/issues/67062 [4]
  Link: https://lore.kernel.org/rust-for-linux/DGUA5GY2DGYN.3PG0FKLG7GFN1@garyguo.net/ [5]

    - Miguel ]

Link: https://github.com/rust-lang/rust-clippy/issues/15852 [1]
Link: https://github.com/rust-lang/rust-clippy/pull/15939

 [2]
Suggested-by: default avatarGary Guo <gary@garyguo.net>
Signed-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Link: https://patch.msgid.link/20260312041934.362840-2-jhubbard@nvidia.com


[ Reworded to replace GitHub-like short link with full URLs in Link tags.
  Reworded reason string to match the style of a couple others we have
  elsewhere. - Miguel ]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent fdbaa9d2

rust/kernel/cpufreq.rs

+1 −0
Original line number Diff line number Diff line
@@ -401,6 +401,7 @@ pub fn to_table(mut self) -> Result<TableBox> { 
/// ```

/// use kernel::cpufreq::{DEFAULT_TRANSITION_LATENCY_NS, Policy};

///

/// #[allow(clippy::double_parens, reason = "False positive before 1.92.0")]

/// fn update_policy(policy: &mut Policy) {

///     policy

///         .set_dvfs_possible_from_any_cpu(true)