Commit 48ab6c9c authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

kconfig: massage the loop in conf_read_simple() 



Make the while-loop code a little more readable.

The gain is that "CONFIG_FOO" without '=' is warned as unexpected data.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 4aced3ec

scripts/kconfig/confdata.c

+13 −6
Original line number Diff line number Diff line
@@ -443,6 +443,10 @@ int conf_read_simple(const char *name, int def) 


	while (getline_stripped(&line, &line_asize, in) != -1) {

		conf_lineno++;



		if (!line[0]) /* blank line */

			continue;



		if (line[0] == '#') {

			if (line[1] != ' ')

				continue;
@@ -458,17 +462,20 @@ int conf_read_simple(const char *name, int def) 
				continue;



			val = "n";

		} else if (memcmp(line, CONFIG_, strlen(CONFIG_)) == 0) {

		} else {

			if (memcmp(line, CONFIG_, strlen(CONFIG_))) {

				conf_warning("unexpected data: %s", line);

				continue;

			}



			sym_name = line + strlen(CONFIG_);

			p = strchr(sym_name, '=');

			if (!p)

			if (!p) {

				conf_warning("unexpected data: %s", line);

				continue;

			}

			*p = 0;

			val = p + 1;

		} else {

			if (line[0] != '\0')

				conf_warning("unexpected data: %s", line);

			continue;

		}



		sym = sym_find(sym_name);