Commit 49988a79 authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman
Browse files

mei: vsc: Do not re-enable interrupt from vsc_tp_reset() 

The only 2 callers of vsc_tp_reset() are:

1. mei_vsc_hw_reset(), which immediataly calls vsc_tp_intr_disable()
   afterwards.

2. vsc_tp_shutdown() which immediately calls free_irq() afterwards.

So neither actually wants the interrupt to be enabled after resetting
the chip and having the interrupt enabled for a short time afer
the reset is undesirable.

Drop the enable_irq() call from vsc_tp_reset(), so that the interrupt
is left disabled after vsc_tp_reset().

Link: https://github.com/intel/ivsc-driver/issues/51


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241106220102.40549-1-hdegoede@redhat.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9aa45ca7

drivers/misc/mei/platform-vsc.c

+0 −2
Original line number Diff line number Diff line
@@ -256,8 +256,6 @@ static int mei_vsc_hw_reset(struct mei_device *mei_dev, bool intr_enable) 


	vsc_tp_reset(hw->tp);



	vsc_tp_intr_disable(hw->tp);



	return vsc_tp_init(hw->tp, mei_dev->dev);

}

drivers/misc/mei/vsc-tp.c

+0 −2
Original line number Diff line number Diff line
@@ -364,8 +364,6 @@ void vsc_tp_reset(struct vsc_tp *tp) 
	gpiod_set_value_cansleep(tp->wakeupfw, 1);



	atomic_set(&tp->assert_cnt, 0);



	enable_irq(tp->spi->irq);

}

EXPORT_SYMBOL_NS_GPL(vsc_tp_reset, VSC_TP);