Commit 49e60333 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

blk-mq: Remove the hctx 'run' debugfs attribute 



Nobody uses the debugfs hctx 'run' attribute. Hence remove this
attribute and also the code that updates the corresponding member
variable.

Suggested-by: default avatarJens Axboe <axboe@kernel.dk>
Cc: Gabriel Ryan <gabe@cs.columbia.edu>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240117203609.4122520-1-bvanassche@acm.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 78fbb92a

block/blk-mq-debugfs.c

+0 −18
Original line number Diff line number Diff line
@@ -479,23 +479,6 @@ static int hctx_sched_tags_bitmap_show(void *data, struct seq_file *m) 
	return res;

}



static int hctx_run_show(void *data, struct seq_file *m)

{

	struct blk_mq_hw_ctx *hctx = data;



	seq_printf(m, "%lu\n", hctx->run);

	return 0;

}



static ssize_t hctx_run_write(void *data, const char __user *buf, size_t count,

			      loff_t *ppos)

{

	struct blk_mq_hw_ctx *hctx = data;



	hctx->run = 0;

	return count;

}



static int hctx_active_show(void *data, struct seq_file *m)

{

	struct blk_mq_hw_ctx *hctx = data;
@@ -624,7 +607,6 @@ static const struct blk_mq_debugfs_attr blk_mq_debugfs_hctx_attrs[] = { 
	{"tags_bitmap", 0400, hctx_tags_bitmap_show},

	{"sched_tags", 0400, hctx_sched_tags_show},

	{"sched_tags_bitmap", 0400, hctx_sched_tags_bitmap_show},

	{"run", 0600, hctx_run_show, hctx_run_write},

	{"active", 0400, hctx_active_show},

	{"dispatch_busy", 0400, hctx_dispatch_busy_show},

	{"type", 0400, hctx_type_show},

block/blk-mq-sched.c

+0 −2
Original line number Diff line number Diff line
@@ -324,8 +324,6 @@ void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx) 
	if (unlikely(blk_mq_hctx_stopped(hctx) || blk_queue_quiesced(q)))

		return;



	hctx->run++;



	/*

	 * A return of -EAGAIN is an indication that hctx->dispatch is not

	 * empty and we must run again in order to avoid starving flushes.

include/linux/blk-mq.h

+0 −3
Original line number Diff line number Diff line
@@ -391,9 +391,6 @@ struct blk_mq_hw_ctx { 
	 */

	struct blk_mq_tags	*sched_tags;



	/** @run: Number of dispatched requests. */

	unsigned long		run;



	/** @numa_node: NUMA node the storage adapter has been connected to. */

	unsigned int		numa_node;

	/** @queue_num: Index of this hardware queue. */