Commit 4ae132c6 authored by Mark Brown's avatar Mark Brown Committed by Andrew Morton
Browse files

selftest: hugetlb_dio: fix test naming 

The string logged when a test passes or fails is used by the selftest
framework to identify which test is being reported.  The hugetlb_dio test
not only uses the same strings for every test that is run but it also uses
different strings for test passes and failures which means that test
automation is unable to follow what the test is doing at all.

Pull the existing duplicated logging of the number of free huge pages
before and after the test out of the conditional and replace that and the
logging of the result with a single ksft_print_result() which incorporates
the parameters passed into the test into the output.

Link: https://lkml.kernel.org/r/20241127-kselftest-mm-hugetlb-dio-names-v1-1-22aab01bf550@kernel.org


Fixes: fae19803 ("selftests: hugetlb_dio: fixup check for initial conditions to skip in the start")
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Reviewed-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Donet Tom <donettom@linux.ibm.com>
Cc: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 965b5dd1

tools/testing/selftests/mm/hugetlb_dio.c

+5 −9
Original line number Diff line number Diff line
@@ -76,19 +76,15 @@ void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off) 
	/* Get the free huge pages after unmap*/

	free_hpage_a = get_free_hugepages();



	ksft_print_msg("No. Free pages before allocation : %d\n", free_hpage_b);

	ksft_print_msg("No. Free pages after munmap : %d\n", free_hpage_a);



	/*

	 * If the no. of free hugepages before allocation and after unmap does

	 * not match - that means there could still be a page which is pinned.

	 */

	if (free_hpage_a != free_hpage_b) {

		ksft_print_msg("No. Free pages before allocation : %d\n", free_hpage_b);

		ksft_print_msg("No. Free pages after munmap : %d\n", free_hpage_a);

		ksft_test_result_fail(": Huge pages not freed!\n");

	} else {

		ksft_print_msg("No. Free pages before allocation : %d\n", free_hpage_b);

		ksft_print_msg("No. Free pages after munmap : %d\n", free_hpage_a);

		ksft_test_result_pass(": Huge pages freed successfully !\n");

	}

	ksft_test_result(free_hpage_a == free_hpage_b,

			 "free huge pages from %u-%u\n", start_off, end_off);

}



int main(void)